Add Code complete #62
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::size_t _cursor_pos = cursor_pos; | ||
| auto text = split_line(code, delims, _cursor_pos); |
There was a problem hiding this comment.
warning: invalid case style for variable '_cursor_pos' [readability-identifier-naming]
| std::size_t _cursor_pos = cursor_pos; | |
| auto text = split_line(code, delims, _cursor_pos); | |
| std::size_t cursor_pos = cursor_pos; | |
| auto text = split_line(code, delims, cursor_pos); |
src/xinterpreter.cpp:260:
- Cpp::CodeComplete(results, code.c_str(), 1, _cursor_pos + 1);
+ Cpp::CodeComplete(results, code.c_str(), 1, cursor_pos + 1);| std::string delims = " \t\n`!@#$^&*()=+[{]}\\|;:\'\",<>?."; | ||
| std::size_t _cursor_pos = cursor_pos; | ||
| auto text = split_line(code, delims, _cursor_pos); | ||
| std::string to_complete = text.back().c_str(); |
There was a problem hiding this comment.
warning: redundant call to 'c_str' [readability-redundant-string-cstr]
| std::string to_complete = text.back().c_str(); | |
| std::string to_complete = text.back(); |
| auto text = split_line(code, delims, _cursor_pos); | ||
| std::string to_complete = text.back().c_str(); | ||
|
|
||
| Cpp::CodeComplete(results, code.c_str(), 1, _cursor_pos + 1); |
There was a problem hiding this comment.
warning: no member named 'CodeComplete' in namespace 'Cpp' [clang-diagnostic-error]
Cpp::CodeComplete(results, code.c_str(), 1, _cursor_pos + 1);
^| Cpp::CodeComplete(results, code.c_str(), 1, _cursor_pos + 1); | ||
|
|
||
| return xeus::create_complete_reply(results /*matches*/, | ||
| cursor_pos - to_complete.length() /*cursor_start*/, |
There was a problem hiding this comment.
warning: narrowing conversion from 'unsigned long' to signed type 'int' is implementation-defined [cppcoreguidelines-narrowing-conversions]
cursor_pos - to_complete.length() /*cursor_start*/,
^| std::regex re(ss.str()); | ||
|
|
||
| std::copy( | ||
| std::sregex_token_iterator(input.begin(), input.begin() + cursor_pos + 1, re, -1), |
There was a problem hiding this comment.
warning: narrowing conversion from 'std::size_t' (aka 'unsigned long') to signed type '__gnu_cxx::__normal_iterator<const char *, std::basic_string>::difference_type' (aka 'long') is implementation-defined [cppcoreguidelines-narrowing-conversions]
std::sregex_token_iterator(input.begin(), input.begin() + cursor_pos + 1, re, -1),
^
|
clang-tidy review says "All clean, LGTM! 👍" |
No description provided.