Skip to content

Conversation

alexander-penev
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.14%. Comparing base (bb9bb85) to head (54aa830).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   49.14%   49.14%           
=======================================
  Files          15       15           
  Lines         643      643           
=======================================
  Hits          316      316           
  Misses        327      327           

@mcbarton
Copy link
Collaborator

mcbarton commented Apr 3, 2024

@alexander-penev What is the difference between the cpp 17 (xcpp) kernel and the C++17 (xcpp) kernel? They appear to be the same.

@alexander-penev
Copy link
Collaborator Author

@alexander-penev What is the difference between the cpp 17 (xcpp) kernel and the C++17 (xcpp) kernel? They appear to be the same.

Yes, maybe we should remove "cpp 17 (xcpp)".

@alexander-penev alexander-penev force-pushed the MergeXeusClangReplMiniNewKernels branch 2 times, most recently from b08ac91 to 54aa830 Compare April 4, 2024 07:34
Copy link
Collaborator

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep share/jupyter/kernels/kernel.json.in ?

@vgvassilev vgvassilev merged commit ce3f8e9 into compiler-research:main Apr 10, 2024
@vgvassilev vgvassilev mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants