Removing redundant EXPORTED_RUNTIME_METHODS for lite #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
commented
Mar 3, 2025
| @@ -445,7 +445,6 @@ if(EMSCRIPTEN) | |||
| # TODO: Remove the exported runtime methods | |||
| # after the next xeus release. | |||
| target_link_options(xcpp | |||
| PUBLIC "SHELL: -s EXPORTED_RUNTIME_METHODS='[\"FS\",\"PATH\",\"LDSO\",\"loadDynamicLibrary\",\"ERRNO_CODES\"]'" | |||
There was a problem hiding this comment.
This is now being enforced through
|
Only change required for lite. For native cases, once this goes in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 81.03% 80.72% -0.31%
==========================================
Files 19 19
Lines 970 970
Branches 93 93
==========================================
- Hits 786 783 -3
- Misses 184 187 +3 |
|
@anutosh491 can you give this PR a better title and description? This PR appears to be less about bumping to 5.2.0, but more removing the redundant EXPORTED_RUNTIME_METHODS in xeus-cpp, given its now taken care of by xeus 5.2.0 |
|
Cool. Yeah we aren't like "bumping" "bumping" but that's a by product of always fetching the latest xeus. |
anutosh491
changed the title
mcbarton
approved these changes
Mar 3, 2025
anutosh491
added a commit
that referenced
this pull request
Mar 5, 2025
mcbarton
pushed a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
There was an update to xeus 5.2.0 and hence this is being raised. We now don't need to export runtime methods through xeus-cpp as they are already done through xeus
Type of change
Please tick all options which are relevant.