Fix examples not working in the lite demo notebook #231
Conversation
|
I realized that some examples from the update lite notebook were not working as expected
Whereas we should see the image here
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
| message(STATUS "Moving headers to ${SYSROOT_PATH}/include/xcpp") | ||
| foreach(header ${XCPP_HEADERS}) | ||
| file(COPY ${header} DESTINATION ${SYSROOT_PATH}/include/xcpp) | ||
| endforeach() |
There was a problem hiding this comment.
For this to work, we need to preload the required headers (xdisplay.hpp and xmime.hpp to a location where they are accessible)
I expected the install command to do the job here.
I even tried avoiding the complexity of handling INTERFACE targets and potential CMake nuances with PUBLIC_HEADER and just tried
install(FILES ${XCPP_HEADERS} DESTINATION ${SYSROOT_PATH}/include/xcpp)
But even this isn't doing the job.
Hence here I am
- Creating the required directory inside
${SYSROOT_PATH}/includethat we are already preloading - Explicitly copying the header files there.
And this works !!
I am not sure why the install isn't comfortable around emscripten !?
But untill someone provides a better solution, this should do the required.
|
Merging to see if this fixes the deployment ! |
Description
Type of change
Please tick all options which are relevant.