Skip to content

Conversation

mcbarton
Copy link
Collaborator

Description

Maybe I'm wrong but I don't feel like we need this restriction on the upper limit for jupyter kernel test.

Please include a summary of changes, motivation and context for this PR.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@mcbarton mcbarton requested a review from anutosh491 January 11, 2025 21:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (ddeb5ca) to head (24dd76e).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   80.72%   80.72%           
=======================================
  Files          19       19           
  Lines         970      970           
  Branches       93       93           
=======================================
  Hits          783      783           
  Misses        187      187           

@anutosh491 anutosh491 changed the title Remove upper limit on jupyter kernel test Upgrade jupyter kernel test to <0.8 Jan 13, 2025
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good catch !

Approving. Will merge after CI passes.

@anutosh491 anutosh491 merged commit 0747fb9 into compiler-research:main Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants