Shallow clone emsdk #215
Merged
Shallow clone emsdk #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
anutosh491
reviewed
Jan 12, 2025
| @@ -41,7 +41,7 @@ jobs: | |||
| shell: bash -l {0} | |||
| run: | | |||
| cd $HOME | |||
| git clone https://github.com/emscripten-core/emsdk.git | |||
| git clone --depth=1https://github.com/emscripten-core/emsdk.git | |||
There was a problem hiding this comment.
Hmmm, just curious if this is correct --depth=1https: !!
There was a problem hiding this comment.
@anutosh491 Good catch. I'd missed the space and has been fixed now. can it be merged now
anutosh491
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
In the ci we clone the whole history for emsdk where we only need the most recent commit. This will provide a very small speed up in the ci.
Fixes # (issue)
Type of change
Please tick all options which are relevant.