fix codegen for operator wrapper #571
Conversation
There was a problem hiding this comment.
LGTM! This fixes the std::chrono test case and functionally brings the wrapper closer to upstream cppyy. The expression !FD->isOverloadedOperator() || (FD->getOverloadedOperator() == clang::OO_Call) can be stored in a flag to improve readability, feel free to merge once that is addressed (and the bots pass)
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
We should add a relevant test.
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
force-pushed
the
dev/chrono
branch
from
6ea4209 to
802d066
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
+ Coverage 76.37% 76.45% +0.07%
==========================================
Files 9 9
Lines 3645 3648 +3
==========================================
+ Hits 2784 2789 +5
+ Misses 861 859 -2
🚀 New features to boost your workflow:
|
Generator operations instead of function calls similar to upstream
similar to upstream
Vipul-Cariappa
force-pushed
the
dev/chrono
branch
from
769796f to
c3e2782
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
A reminder to squash into a single commit before merging :) |
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Lgtm. Please use squash on merge.
3 participants
Description
Generator operations instead of function calls similar to upstream
Fixes # (issue)
fixes
test_cpp11features.py::TestCPP11FEATURES::test11_chronoin cppyyType of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist