Skip to content

chore: fix generated query function promise type #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

rodymolenaar
Copy link
Contributor

This fixes TypeScript errors complaining about assigning to Promise#cancel. I chose for a specific CancellablePromise<T> type instead of extending the globalThis promise.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

==== Benchmark result ====


Total benchmarks: 9
          Passed: 9
          Failed: 0
-----------
object validator simple      5000000  iterations     474  ns/op
object validator nested        50000  iterations   46968  ns/op
logger - strings              500000  iterations    3303  ns/op
logger - objects              500000  iterations    4373  ns/op
logger - deep objects         200000  iterations    5017  ns/op
uuid                         2000000  iterations     552  ns/op
uuid.isValid                10000000  iterations     161  ns/op
isNil                      500000000  iterations       0  ns/op
isPlainObject              100000000  iterations      19  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2020

==== C8 test coverage ====
Statements: 79.04% ( 15944/20171 )
Branches : 78.38% ( 1932 /2465 )
Functions : 75.07% ( 554 /738 )
Lines : 79.04% ( 15944 /20171 )

@dirkdev98
Copy link
Member

You probably want a release as soon as possible?

@dirkdev98
Copy link
Member

We should really have #78 so these kind of things are catched before release

@dirkdev98 dirkdev98 merged commit eb2a920 into main Oct 6, 2020
@dirkdev98 dirkdev98 deleted the chore/query-type-fix branch October 6, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants