Skip to content

add react-query code-gen e2e testing #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dirkdev98 opened this issue Jun 28, 2020 · 3 comments
Closed

add react-query code-gen e2e testing #78

dirkdev98 opened this issue Jun 28, 2020 · 3 comments
Labels
prio 2 Issues with a lower prio, mostly features

Comments

@dirkdev98
Copy link
Member

Depends on: testing-library/react-hooks-testing-library#68
@dirkdev98
Copy link
Member Author

Currently spammed with:

Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.
        in TestHook
        in Suspense

most likely the same issue as above. However I'm short on time these weeks, so will probably look again in a few weeks

@dirkdev98 dirkdev98 added prio 1 Defines the highest prio issues and removed @lbu/code-gen labels Sep 9, 2020
@dirkdev98 dirkdev98 added prio 2 Issues with a lower prio, mostly features and removed prio 1 Defines the highest prio issues labels Oct 1, 2020
@dirkdev98
Copy link
Member Author

Not sure yet when to do it, but currently the tooling is not there yet, so postpone

@dirkdev98 dirkdev98 mentioned this issue Oct 6, 2020
Merged
@dirkdev98
Copy link
Member Author

dirkdev98 commented Oct 6, 2020 •
edited
Loading

Now that we have E2E testing, at least we run a full Typescript build externally, so we know when it's broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio 2 Issues with a lower prio, mostly features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirkdev98