Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cz init
modifies.pre-commit-config.yaml
in a deprecated way. This PR fixes that, however, pre-commit must be upgraded to v3.2.0 onwards.Currently, commitizen is writing something like this to
.pre-commit-config.yaml
:However, pre-commit will complaint that it's deprecated like mentioned in #1560 .
The upstream modification was proposed in pre-commit/pre-commit#2732, and fixed in pre-commit/pre-commit#2808
That means, "pre-push" starts to be usable in v3.2.0, while "push" starts to be deprecated.
This changed has already been stated in https://github.com/commitizen-tools/commitizen/blob/master/docs/README.md?plain=1#L209
Consequently, these modifications were made:
Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
See commitizen generates config like this:
Steps to Test This Pull Request
cz init
Additional Context
Close #1560