Skip to content

fix(docs): fix the regex and examples in the monorepo documentation #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

baluyotraf
Copy link
Contributor

Description

The regex in the monorepo example seems to follow the Python formatting, but the toml text should follow the raw string instead (unless this library internally calls eval?).

Also the example does not follow regex format in the setting.

Checklist

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Update the regex pattern and update the example regex.

Steps to Test This Pull Request

Additional context

Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (120d514) to head (8a30015).
Report is 592 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   97.33%   97.55%   +0.21%     
==========================================
  Files          42       57      +15     
  Lines        2104     2656     +552     
==========================================
+ Hits         2048     2591     +543     
- Misses         56       65       +9     
Flag Coverage Δ
unittests 97.55% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@baluyotraf baluyotraf changed the title Fix the changelog_pattern regex in the monorepo tutorial fix(docs): fix the regex and examples in the monorepo documentation May 5, 2025
@Lee-W Lee-W force-pushed the fix/monorepo-regex branch from 3e42546 to 8a30015 Compare May 6, 2025 01:36
@Lee-W
Copy link
Member

Lee-W commented May 6, 2025

Looks like our poetry ci command is not running commitizen correctly. 🤔 I just fixed the commit message

@Lee-W Lee-W merged commit a3682d5 into commitizen-tools:master May 6, 2025
16 checks passed
@Lee-W
Copy link
Member

Lee-W commented May 6, 2025

I think commitizen-branch was wrongly implemented. I create a draft PR to keep track of it and hope I can wrap it up some time...

#1400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants