Refine text tags #232
Merged
Refine text tags #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a regression introduced during the Scala 3 upgrade where the `scalatags.Text.all.doctype` case class no longer worked with the pre-existing tags since its second argument accepts a `scalatags.text.Frag` but the tags themselves refined to `<tag-name>.Self` (the <tag-name> is a placeholder for the tag's name). As it turns out, this self type was not being refined by the tags themselves because for some reason, the Scala 3 compiler resolves this type to be `scalatags.generic.TypedTag` i.e. it resolves to the more generic type as opposed to the more specific type of `scalatags.Text.TypedTag`. Fortunately in Scala 2, this works out fine as the type does get refined and therefore the tags can be used inside a `scalatags.text.Frag`. This commit essentially adds type annotations to all the tags under the text package so that the more specific `ConcreteHtmlTag[String]` is used instead of the more generic `TypedTag`.
lolgab
reviewed
Dec 17, 2021
|
|
||
|
|
||
| def check(txt: String, expected: String) = { | ||
| // augmentString = work around scala/bug#11125 on JDK 11 |
There was a problem hiding this comment.
If you use linesIterator then you can probably remove the Predef.augmentSring workaround and the comment.
Anyways, I would do that in a separate PR.
There was a problem hiding this comment.
Probably. I only replaced lines with linesIterator since it gave warnings about lines being deprecated or something.
|
Actually I had to do this in other tags to make the tests pass. But I didn't do for all of them so I created a bug. |
lolgab
approved these changes
Dec 17, 2021
|
@lolgab would you mind releasing a new version with these changes? |
|
@keynmol Thanks for the reminder. Pushed version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #231. This essentially refines the tag types so that the tags can actually be used inside the
doctype's case class constructor.