-
Notifications
You must be signed in to change notification settings - Fork 501
Update README around multi-dictionary changes #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would you mind to add a table with the existing dictionaries and shortly say, which are used as a default? I know it now, but the information would be helpful for new people using the code. |
I don't really want to add something separately as it's just another thing to forget to update and become stale. It's within the help here: We could mention that somewhere on this page, but I'm not quite sure where. |
|
Adding a reference to the builtin section is fine for me. But if you just read the dictionary part and Readme, it is not really clear. |
I would add a tiny test (pytest) that looks for It would be good to have the dictionary list in human-readable form. We can also tell people to do |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternewman do you want to take a stab at a better phrasing inspired by #1535 so we can close that one when we merge this, then cut a release?
|
Ping @peternewman , would be nice to move on this so we can release |
|
Thanks @peternewman |
Sorry @larsoner , various stuff got a bit mad, plus trying to hit a release deadline for something else I help maintain. I'll generate some issues for the other things we discussed. |
No description provided.