This repository was archived by the owner on Dec 31, 2021. It is now read-only.
Use of blank? instead of nil? to check hash value #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderanger
added a commit
that referenced
this pull request
May 21, 2012
Use of blank? instead of nil? to check hash value
|
Thanks for the patch, looks like at some point Chef stopped bundling ActiveSupport's Object#blank? hack. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collectd_plugin.rb checks if values in the params hash are blank. I think it should check if they are nil instead.
This resolves the error "NoMethodError: undefined method `blank?' for nil:NilClass" for me with ruby 1.8.7 and chef 0.10.10.