Skip to content

fix(lib/vscode): fix missing rimraf when running postinstall script #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2021
Merged

fix(lib/vscode): fix missing rimraf when running postinstall script #3383

merged 1 commit into from
May 13, 2021

Conversation

kenve
Copy link
Contributor

@kenve kenve commented May 13, 2021

Fix the error that rimraf is missing when running yarn --production.

$ node ./postinstall
internal/modules/cjs/loader.js:818
  throw err;
  ^

Error: Cannot find module 'rimraf'

@kenve kenve requested a review from a team as a code owner May 13, 2021 05:48
code-asher
code-asher approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing this!

@code-asher code-asher merged commit 8e21eb5 into coder:main May 13, 2021
@code-asher code-asher mentioned this pull request May 13, 2021
Closed
@jsjoeio jsjoeio added this to the v3.11.0 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kenve @code-asher @jsjoeio