-
Notifications
You must be signed in to change notification settings - Fork 6.4k
feat(testing): add e2e tests for code-server and terminal #3169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ecc7d6a to
0ec7ae4
Compare
2977bc6 to
958aa84
Compare
|
Womp. 404. Network issue. I wonder if we could automatically retry if it 404s? cc @oxy |
|
@jsjoeio sadly there's no "please re-run the same step" within an action on GitHub - and we don't have control over I think I can address this in a future PR where we split up all the things to upload to different artifacts, eg. (file starts uploading from one action (eg. |
Okay, sounds good!
Yeah, that could be a good idea too! I'll leave that to you if you want. |
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new model!
Codecov Report
@@ Coverage Diff @@
## main #3169 +/- ##
==========================================
+ Coverage 46.77% 46.86% +0.08%
==========================================
Files 23 23
Lines 1193 1195 +2
Branches 237 237
==========================================
+ Hits 558 560 +2
Misses 451 451
Partials 184 184
Continue to review full report at Codecov.
|
I think this is cause I started this PR before Codecov was added. We'll see though in the next PR on code-server. |
8524265 to
f40f468
Compare
f40f468 to
a404e59
Compare
a404e59 to
7bfdd13
Compare

This PR adds a test for the integrated terminal in code-server.
Changes
CodeServerclass for simplifying testing (thank you @jawnsy for the POM tip!)CodeServerexpectin a couple e2e tests (I forgot.toBe(true))Screenshots
69c0ddcb7541307f217a818f94992163.mp4
Checklist
terminal_e2e_test.txtCodeServer.focusTerminal()methodtmpdirwaitForTimeouts interminal.test.tstry changingI don't want to mess with this. If someone wants to create a ticket to check out later, go for it. Otherwise, I'll add a note to the "Clean up" issueesModuleInteropto false