-
Notifications
You must be signed in to change notification settings - Fork 6.4k
dev(testing): add jest-playwright and reduce flakiness of e2e tests #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d691960 to
4e8b287
Compare
3439941 to
ddeebfe
Compare
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to move the playwright-* packages to devDependencies, and am not sure about .eslintrc order but looks good otherwise!
1381081 to
ca8f832
Compare
ca8f832 to
ad0f12e
Compare
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Hi @jsjoeio! Would you consider trying |
This PR adds
jest-playwrightand refactors the e2e tests to hopefully reduce the flakiness.Changes
jest-playwrightin preparation of [dev]: enable end-to-end test suite on Safari and Firefox #2998Protocol error (Browser.removeBrowserContext): Browser closedmicrosoft/playwright#6020 is fixedglobalSetupto manually create cookie for auth reusejest-playwright--runInBand(opposite of in parallel)Screenshots
Checklist
logouttestmaybeUpdatedCookiesRelated: