-
Notifications
You must be signed in to change notification settings - Fork 6.4k
dev: add release:prep script #2952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a0a96f to
191cbe3
Compare
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 36 of the script, you're checking for hub but towards the end of the script, you're using gh - they're not the same tool!
| fi | ||
|
|
||
| # Check that hub is installed | ||
| if ! command -v hub &>/dev/null; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check for gh instead of hub here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they're not the same tool!
I may be a noob at writing scripts but I'm not THAT much of a noob.
I know they're not the same tool 😂 That's intentional!
gh is hub's successor, hence why I'm using it here. Eventually, the plan is to remove the use of hub and only use gh but now, the maintainer releasing should have both because it's used here and here.
I'll make a follow-up issue to remove the use of hub and replace with gh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we check for gh elsewhere? I'm not too sure >.<
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the update-vscode script too since it's used there.
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome to see this automated!
7f786f4 to
a94589d
Compare
a94589d to
42eb7c4
Compare
oxy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
code-asher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
42eb7c4 to
299e17e
Compare
This PR adds a new script called
release:prepto help with the release process by asking for the new version and then automating the following steps:package.jsonChart.yaml.Demo
Screen.Recording.2021-03-23.at.11.41.06.AM.mov
TODOS
CMD="echo"git addmistake