Skip to content

chore: Remove pages/update.css #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

chore: Remove pages/update.css #2823

merged 1 commit into from
Mar 5, 2021

Conversation

@greyscaled
Copy link
Contributor

@greyscaled greyscaled commented Mar 5, 2021 •
edited
Loading

It appears the associated HTML for these styles was removed in
554b6d6. I tried searching the repository for .update-form and the only hit was that CSS file

@greyscaled
chore: Remove pages/update.css
9e2668e 
It appears the associated HTML for these styles was removed in
554b6d6
@greyscaled greyscaled requested a review from code-asher March 5, 2021 11:55
@greyscaled greyscaled self-assigned this Mar 5, 2021
@greyscaled greyscaled requested a review from a team as a code owner March 5, 2021 11:55
@jsjoeio jsjoeio mentioned this pull request Mar 5, 2021
Closed
jsjoeio
jsjoeio approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with the Clean Up initiative! 🧹

I have been wanting for us to look at removing dead code and added this to the roadmap item: #2818

awesome

@jsjoeio jsjoeio merged commit f21433a into main Mar 5, 2021
@jsjoeio jsjoeio deleted the vapurrmaid/rm-updatecss branch March 5, 2021 21:04
@jsjoeio jsjoeio added this to the v3.9.1 milestone Mar 5, 2021
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@code-asher code-asher Awaiting requested review from code-asher

1 more reviewer

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@greyscaled greyscaled

Labels

chore Related to maintenance or clean up

Projects

None yet

Milestone

v3.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@greyscaled @jsjoeio