ci: Add support for FreeBSD to the build process #2466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Need to fix some other scripts rn as well. |
nhooyr
force-pushed
the
freebsd-abe7
branch
3 times, most recently
from
fcdb9a0 to
fd79538
Compare
We don't have an agent for FreeBSD right now.
Now that we've moved to the submodule, there is no need to reset changes in there :) cc @jsjoeio
Electron doesn't support FreeBSD.
jsjoeio
approved these changes
Dec 18, 2020
Contributor
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
All looks good as usual! 🌮
Only question was about removing electron as a package. If that was intentional, should we also remove lib/vscode/src/typings/electron.d.ts?
Contributor
Author
|
@jsjoeio See commit 3 |
Contributor
|
@nhooyr got it! Looks good! 🚀 (side note: would be curious to hear why we should keep the types for my own learning?) |
Contributor
Author
VS Code won't compile without it. We still compile the electron parts for some reason. I asked @code-asher and he said the easiest way to avoid problems is just to include the types to quiet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1826
Updates #1880
Updates #2320
Updates #2349