-
Notifications
You must be signed in to change notification settings - Fork 56
cleaning unnecesary injections within MainActivity, updating build tools and dependencies #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…jects cleaning unnecesary injections within MainActivity
app/build.gradle
Outdated
buildToolsVersion "23.0.3" | ||
compileSdkVersion 28 | ||
buildToolsVersion '28.0.3' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this line now. It's not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean the empty one?
build.gradle
Outdated
repositories { | ||
jcenter() | ||
maven { | ||
url 'https://maven.google.com/' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use google() now in Gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added! Commit b1e33a5
build.gradle
Outdated
allprojects { | ||
repositories { | ||
jcenter() | ||
maven { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added! Commit b1e33a5
Uh oh!
There was an error while loading. Please reload this page.