Skip to content

Conversation

eduardogr
Copy link

@eduardogr eduardogr commented Jun 20, 2019

  • cleaning unnecesary injections wihtin MainActivity, fixing Main Activity Inject #5
  • updating android sdk to 28
  • updating buildtools also
  • updating dependencies
  • cleaning code a little

app/build.gradle Outdated
buildToolsVersion "23.0.3"
compileSdkVersion 28
buildToolsVersion '28.0.3'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line now. It's not needed

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the empty one?

build.gradle Outdated
repositories {
jcenter()
maven {
url 'https://maven.google.com/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use google() now in Gradle

Copy link
Author

@eduardogr eduardogr Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! Commit b1e33a5

build.gradle Outdated
allprojects {
repositories {
jcenter()
maven {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Author

@eduardogr eduardogr Jun 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! Commit b1e33a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants