Skip to content

fix: replace url_is() #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: replace url_is() #915

merged 1 commit into from
Oct 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 18, 2023

Description
url_is() checks the URI path. If the path is changed by devs, it will not work.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: replace url_is()
a8287bb 
url_is() checks the URI path. If the path is changed, it will not work.
@kenjis kenjis added the bug Something isn't working label Oct 18, 2023
@kenjis kenjis merged commit 46a6da7 into codeigniter4:develop Oct 18, 2023
@kenjis kenjis deleted the fix-remove-url_is branch October 18, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @lonnieezell @datamweb