Skip to content

Conversation

datamweb
Copy link
Contributor

@datamweb datamweb commented Feb 2, 2023

@datamweb
Copy link
Contributor Author

datamweb commented Feb 2, 2023

@kenjis I tried to fix error psalm error, but I'm not sure, please review.

Warning: "findUnusedBaselineEntry" will be defaulted to "true" in Psalm 6. You should explicitly enable or disable this setting.
Warning: "findUnusedCode" will be defaulted to "true" in Psalm 6. You should explicitly enable or disable this setting.
Target PHP version: 7.4 (inferred from composer.json) Enabled extensions: .
Scanning files...
Deprecation: Psalm stubs for ext-apcu loaded using legacy way. Instead, please declare ext-apcu as dependency in composer.json or use <enableExtensions> and/or <disableExtensions> directives in Psalm config.
Deprecation: Psalm stubs for ext-redis loaded using legacy way. Instead, please declare ext-redis as dependency in composer.json or use <enableExtensions> and/or <disableExtensions> directives in Psalm config.
Analyzing files...

░░░░░░E░░░░░░░

ERROR: ReservedWord - src/Handlers/DatabaseHandler.php:173:31 - 'resource' is a reserved word (see https://psalm.dev/095)
        if (is_bool($result = $query->get())) {


------------------------------
1 errors found
------------------------------
87 other issues found.
You can display them with --show-info=true
------------------------------
Psalm can automatically fix 30 of these issues.
Run Psalm again with 
--alter --issues=MissingReturnType --dry-run
to see what it can fix.
------------------------------

Checks took 3.43 seconds and used 457.239MB of memory
Psalm was able to infer types for 90.97[13](https://github.com/codeigniter4/settings/actions/runs/3984651256/jobs/6831102637#step:9:14)% of the codebase
Error: Process completed with exit code 2.

@kenjis kenjis added the github_actions Pull requests that update GitHub Actions code label Feb 3, 2023
@kenjis
Copy link
Member

kenjis commented Feb 3, 2023

@datamweb It is reported in https://github.com/codeigniter4/settings/actions/runs/4075126980/jobs/7021112053
but the psalm error is not reported now.

@kenjis
Copy link
Member

kenjis commented Feb 3, 2023

It seems it is vimeo/psalm#2625

It seems we need to define @psalm-type:
https://psalm.dev/r/1eb2ffcac4
or @phpstan-type:
https://psalm.dev/r/8be0fb54b4

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MGatner MGatner merged commit 51ec381 into codeigniter4:develop Feb 6, 2023
@datamweb datamweb deleted the use-GITHUB_TOKEN branch February 6, 2023 11:13
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Apr 14, 2023
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Apr 25, 2023
kenjis added a commit to kenjis/CodeIgniter4 that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants