Skip to content

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 23, 2024

Description
Fixes #9063

$routes->group('', ['filter' => ['csrf']], static function ($routes) {
    $routes->get('getuserinfo', 'Mmeber::getUserInfo', ['filter' => ['honeypot']]);
});

Before:

+--------+-------------+------+--------------------------------------+----------------+---------------+
| Method | Route       | Name | Handler                              | Before Filters | After Filters |
+--------+-------------+------+--------------------------------------+----------------+---------------+
| GET    | getuserinfo | »    | \App\Controllers\Mmeber::getUserInfo | honeypot       | honeypot      |
+--------+-------------+------+--------------------------------------+----------------+---------------+

After:

+--------+-------------+------+--------------------------------------+----------------+---------------+
| Method | Route       | Name | Handler                              | Before Filters | After Filters |
+--------+-------------+------+--------------------------------------+----------------+---------------+
| GET    | getuserinfo | »    | \App\Controllers\Mmeber::getUserInfo | csrf honeypot  | honeypot csrf |
+--------+-------------+------+--------------------------------------+----------------+---------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 23, 2024
@kenjis kenjis force-pushed the fix-route-group-filters branch from 30163ea to cd4698d Compare July 23, 2024 07:57
@kenjis kenjis force-pushed the fix-route-group-filters branch from cd4698d to e580856 Compare July 23, 2024 08:08
@kenjis kenjis merged commit f18b8f2 into codeigniter4:develop Jul 26, 2024
@kenjis kenjis deleted the fix-route-group-filters branch July 26, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Routing groups and in-group routes use filters that are only effective within the group.
4 participants