Skip to content

fix: OCI8 Forge always sets NOT NULL when BOOLEAN is specified #8440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: OCI8 Forge always sets NOT NULL when BOOLEAN is specified #8440

merged 1 commit into from
Jan 23, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 21, 2024 •
edited
Loading

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jan 21, 2024
@kenjis kenjis mentioned this pull request Jan 21, 2024
Merged
5 tasks
@kenjis kenjis merged commit 945da21 into codeigniter4:develop Jan 23, 2024
@kenjis kenjis deleted the fix-OCI8-Forge-BOOLEAN-null branch January 23, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn