Skip to content

Parse and forward JavaC 'Note:' level messages #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Parse and forward JavaC 'Note:' level messages #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0fcf2e
Parse and forward JavaC 'Note:' level messages
mensinda May 30, 2023
c47b7b8
Merge branch 'master' into infoLogs
gnodet Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...plexus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavacCompiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ else if ( ( buffer.length() == 0 ) && line.startsWith( "warning: " ) )
}
else if ( ( buffer.length() == 0 ) && isNote( line ) )
{
// skip, JDK 1.5 telling us deprecated APIs are used but -Xlint:deprecation isn't set
errors.add( new CompilerMessage( line, CompilerMessage.Kind.NOTE ) );
}
else if ( ( buffer.length() == 0 ) && isMisc( line ) )
{
Expand Down
10 changes: 10 additions & 0 deletions ...mpiler-javac/src/test/java/org/codehaus/plexus/compiler/javac/ErrorMessageParserTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,16 @@ public void testErrorMessage()
assertThat( compilerError.getEndLine(), is(7) );
}

@Test
public void testNoteMessage() throws IOException
{
String error = "Note: My fancy annotation processor info" + EOL;
List<CompilerMessage> messages = JavacCompiler.parseModernStream(0, new BufferedReader(new StringReader(error)));
assertThat(messages.size(), is(1));
assertThat(messages.get(0).isError(), is(false));
assertThat(messages.get(0).getMessage(), is("My fancy annotation processor info"));
}

@Test
public void testUnknownSymbolError()
{
Expand Down