Require Faraday >= 0.9.0 in gemspec #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #115 we started configuring Faraday to use the FlatParamsEncoder to avoid an issue with dropped parameters when building a request url. Unfortunately, as FlatParamsEncoder was only added on Faraday 0.9.0 we should require that version as a minimum, otherwise clients may get confusing error messages after upgrading to the latest hyperclient version. Fixes #117
|
Small enough fix, going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #115 we started configuring Faraday to use the FlatParamsEncoder to
avoid an issue with dropped parameters when building a request url.
Unfortunately, as FlatParamsEncoder was only added on Faraday 0.9.0
we should require that version as a minimum, otherwise clients may get
confusing error messages after upgrading to the latest hyperclient
version.
Fixes #117