Skip to content

Conversation

benbot
Copy link
Contributor

@benbot benbot commented Oct 17, 2017

It's a lot nicer getting immediate feedback via a push notification when a build finishes. This way you never really need to look at the terminal other than for logs.

@benbot
Copy link
Contributor Author

benbot commented Oct 18, 2017

Any idea why that build is failing? I trying go getting on a clean GOPATH and it ran fine.

@ibash
Copy link
Collaborator

ibash commented Oct 18, 2017

@benbotwin looks like it might be due to wercker using an old version of go:

$ go version
go version go1.2 linux/amd64
$ go get -t ./...
# github.com/mattn/go-shellwords
../../mattn/go-shellwords/util_posix.go:17: eerr.Stderr undefined (type *exec.ExitError has no field or method Stderr)

You could try adding a wercker.yml with a newer version

@benbot
Copy link
Contributor Author

benbot commented Oct 18, 2017

apparently wrecker doesn't have any other versions.

Also, i'll clean up these commits and make a new PR once I have this figured out

@ibash
Copy link
Collaborator

ibash commented Oct 18, 2017

@benbotwin does box: golang:1.9.1 work?

@benbot
Copy link
Contributor Author

benbot commented Oct 19, 2017

Nope. @ibash is there a list of wrecker boxes somewhere? I thought it was pulling containers from docker hub, but that doesn't seem to be the case.

@benbot
Copy link
Contributor Author

benbot commented Oct 20, 2017

@ibash I got the build working and I squashed all the commits here 😄 . Let me know if there's anything you think would need adding or fixing

@ibash
Copy link
Collaborator

ibash commented Oct 20, 2017

Thanks @benbotwin! There seems to be one test that is not passing, barring that this is good to go!

@benbot
Copy link
Contributor Author

benbot commented Oct 21, 2017

@ibash I'm not sure why that failed but it looks all good now :)

@ibash ibash merged commit 0124369 into codegangsta:master Oct 23, 2017
@ibash
Copy link
Collaborator

ibash commented Oct 23, 2017

Thank you!!

RenovZ pushed a commit to RenovZ/gen that referenced this pull request Mar 25, 2022
Added push notifications when a build fails or finished
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants