Skip to content

feat: convert runtimeImages to map #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikhail-klimko merged 34 commits into from
Jul 8, 2025
Merged

feat: convert runtimeImages to map #588

mikhail-klimko merged 34 commits into from
Jul 8, 2025

Conversation

@mikhail-klimko
Copy link
Collaborator

@mikhail-klimko mikhail-klimko commented Jul 7, 2025 •
edited
Loading

What

Convert .Values.engine.runtimeImages to maps of images.

Why

To use cf-common.image.name template from libs and respect .Values.global.imageRegistry if provided

Notes

For backward compatibility added an option to specify runtimeImages the old way (takes priority if specified!)

    runtimeImages:
      COMPOSE_IMAGE: quay.io/codefresh/compose:v2.37.0-1.5.4@sha256:e74494370100678ccb1c1058e6ef3ddcf67b21fcd37da8b3482376c8282549ad
      CONTAINER_LOGGER_IMAGE: quay.io/codefresh/cf-container-logger:1.12.5@sha256:9152151faf828dfd3bf52ea568b6d70bcc88ef99d5fa7d011f7b4d9beed652cc
      DOCKER_BUILDER_IMAGE: quay.io/codefresh/cf-docker-builder:1.4.6@sha256:94683c11ac66705ef752b7d4c7f8fb57445cb96d4f1425a52b5b3a9428ec852b
   ....

@mikhail-klimko mikhail-klimko marked this pull request as ready for review July 7, 2025 08:43
@mikhail-klimko mikhail-klimko requested a review from a team as a code owner July 7, 2025 08:43
@mikhail-klimko mikhail-klimko merged commit 4faae6d into main Jul 8, 2025
2 checks passed
@mikhail-klimko mikhail-klimko deleted the feat/runtime-images-map branch July 8, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zarbis zarbis zarbis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikhail-klimko @zarbis