-
Notifications
You must be signed in to change notification settings - Fork 8
Release 0.2.14 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Release 0.2.14 #61
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b4c1a86
fix private registry utility bug and switch to unprivileged nginx
ilia-medvedev-codefresh 315156d
update argocd
ilia-medvedev-codefresh acc8ef9
update argocd
ilia-medvedev-codefresh fbdbade
bump app-proxy (#59)
danielm-codefresh 2a5894b
add enrichment images to chart
ilia-medvedev-codefresh b0198ee
fix lint
ilia-medvedev-codefresh 61d7a30
change app-proxy container port
mikhail-klimko 1ba2c83
update changes annotation
mikhail-klimko 91567e3
bump app-proxy
mikhail-klimko fa0036b
upd Chart.yaml
mikhail-klimko 586268f
helm-docs
mikhail-klimko d686258
resolver values for internal-router
mikhail-klimko f5e817c
add codeowners
ilia-medvedev-codefresh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this and the livenessProbe should also be 8080 now.
Also, why are you changing this only for the internal-router?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilia-medvedev-codefresh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liveness probe works by port name. If you look at the definition of the port here, you see the port is 8080 but the name is http https://github.com/codefresh-io/gitops-runtime-helm/blob/b0198ee8402129041703e08c0de53eb5f891db7f/charts/gitops-runtime/templates/_components/internal-router/_deployment.yaml#L40C18-L40C18. We are changing it for internal-router because we are switching to unprivileged Nginx to be able to run on rootless (and Openshift). The rest of the components already run rootless
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh by bad, I didn't notice that. Thanks :)