Skip to content

feat: global constraints #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 12, 2025
Merged

feat: global constraints #469

merged 18 commits into from
May 12, 2025

Conversation

@mikhail-klimko
Copy link
Contributor

@mikhail-klimko mikhail-klimko commented May 5, 2025 •
edited
Loading

What

Allow option to provide constraints from .Values.global

global:
  nodeSelector:
    alice: bob
  tolerations:
    - key: test
      operator: Equal
      value: test
      effect: NoSchedule

nodeSelectors and tolerations will be consumed by the following subcharts:

  • argo-events
  • argo-rollouts
  • argo-workflows
  • cf-argocd-extras
  • codefresh-gitops-operator
  • codefresh-tunnel-client
    and gitops-runtime templates (app-proxy/internal-router/hook/etc)

Why

https://codefresh-io.atlassian.net/browse/CR-27877

Notes

@mikhail-klimko mikhail-klimko changed the title Feat/global constraints feat: global constraints May 5, 2025
@mikhail-klimko
Copy link
Contributor Author

mikhail-klimko commented May 8, 2025

/e2e

@mikhail-klimko
Copy link
Contributor Author

mikhail-klimko commented May 12, 2025

/e2e

@mikhail-klimko
Copy link
Contributor Author

mikhail-klimko commented May 12, 2025

/e2e

1 similar comment
@mikhail-klimko
Copy link
Contributor Author

mikhail-klimko commented May 12, 2025

/e2e

@mikhail-klimko mikhail-klimko marked this pull request as ready for review May 12, 2025 09:12
@mikhail-klimko mikhail-klimko requested review from a team as code owners May 12, 2025 09:12
@mikhail-klimko
Copy link
Contributor Author

mikhail-klimko commented May 12, 2025

/e2e

@mikhail-klimko mikhail-klimko merged commit f7c8103 into main May 12, 2025
3 checks passed
@mikhail-klimko mikhail-klimko deleted the feat/global-constraints branch May 12, 2025 10:03
ilia-medvedev-codefresh pushed a commit that referenced this pull request May 14, 2025
@mikhail-klimko @ilia-medvedev-codefresh
feat: global constraints (#469)
3b6b92b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zarbis zarbis zarbis approved these changes

@shirtabachii shirtabachii shirtabachii approved these changes

@ilia-medvedev-codefresh ilia-medvedev-codefresh ilia-medvedev-codefresh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikhail-klimko @zarbis @shirtabachii @ilia-medvedev-codefresh