CR-17878 - support on-prem platform ca #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noam-codefresh
commented
Apr 24, 2023
| {{- define "cap-app-proxy.resources" }} | ||
| {{ include "cap-app-proxy.resources.configmap" . }} | ||
| --- | ||
| {{- if .Values.global.codefresh.caCertificate }} |
Author
There was a problem hiding this comment.
do we even need this file?
noam-codefresh
commented
Apr 24, 2023
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: Helm | ||
| app.kubernetes.io/part-of: events-reporter |
Author
There was a problem hiding this comment.
the part-of were already rendered by the selectorLabels include above
noam-codefresh
force-pushed
the
CR-17878-platform-ca
branch
from
a32823b to
4c7c532
Compare
noam-codefresh
changed the title
noam-codefresh
force-pushed
the
CR-17878-platform-ca
branch
from
337f9f3 to
1a97d38
Compare
noam-codefresh
force-pushed
the
CR-17878-platform-ca
branch
from
c90b7be to
f9cd371
Compare
ilia-medvedev-codefresh
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.