crud for team #213
Merged
crud for team #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .positional('name', { | ||
| describe: 'Name of team', | ||
| }) | ||
| .option('team-file', { |
Contributor
There was a problem hiding this comment.
there is already a general option to create resource from file , with -f option , there is no need to add a specific option 'team-file' , you can take a look on the other resources with create option
|
|
||
| let teams = await team.getTeams(); | ||
|
|
||
| if (!_.isEmpty(teamsIds) && !_.isEmpty(teams)) { |
Contributor
There was a problem hiding this comment.
when you get a id/name , its better you will do the filtering in the back end . pass it as a query or a param , instead of get all and filter it in the cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.