Skip to content

Refactor/validations and cleanup #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor/validations and cleanup #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0245860
Move @PostMapping above Javadoc for updateEmailInfo method
manirajyadav-1 Oct 5, 2025
328fb56
Add @Valid annotations for request validation and remove unused Princ…
manirajyadav-1 Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Backend/src/main/java/idealab/api/controller/MailController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ public ResponseEntity<?> sendEmail(@RequestBody MailRequest mailRequest) {
return new ResponseEntity<>(response, response.getHttpStatus());
}

@PostMapping("/info")
/**
* This updates the email and password associated with the application.
* @param request
* @return
*/
@PostMapping("/info")
public GenericResponse updateEmailInfo(@RequestBody UpdateEmailInfoRequest request) {
String email = request.getEmail();
String pw = request.getPassword();
Expand Down
4 changes: 2 additions & 2 deletions Backend/src/main/java/idealab/api/controller/PrintJobController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public ResponseEntity<?> printJobGetAll(@RequestParam(required = false) String s

// TODO W.E. : add query param or boolean to model to accept mass upload (ignore 5 file max)
@PostMapping
public ResponseEntity<?> printJobNew(@ModelAttribute PrintJobNewRequest model, Principal principal) {
public ResponseEntity<?> printJobNew(@Valid @ModelAttribute PrintJobNewRequest model, Principal principal) {
DataResponse<BasicPrintJob> response = printJobOperations.newPrintJob(model, principal);

return new ResponseEntity<>(response, response.getHttpStatus());
Expand Down Expand Up @@ -109,7 +109,7 @@ public ResponseEntity<?> getDeletablePrintJobs() {

//Don't include the field in the JSON if you dont want it updated
@PutMapping("/{print-id}")
public ResponseEntity<?> updatePrintJobProperties(@PathVariable("print-id") Integer printId, @RequestBody UpdatePrintJobPropertiesRequest request, Principal principal) {
public ResponseEntity<?> updatePrintJobProperties(@PathVariable("print-id") Integer printId, @RequestBody UpdatePrintJobPropertiesRequest request) {
DataResponse<BasicPrintJob> response = printJobOperations.updatePrintJobProps(printId, request);
return new ResponseEntity<>(response, response.getHttpStatus());
}
Expand Down