Show only chapter organisers on workshop edit page #2370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were fetching and making it selectable all of the existing members, which actually slowed down the whole page.
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the workshop edit page by limiting the organiser selection dropdown to only show chapter organisers instead of all members. This change improves page performance by reducing the number of options in the dropdown.
- Changed the collection source from
Member.allto@workshop.chapter.organisers - Updated the selected value extraction to use
pluck(:id)instead ofmap(&:id)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
matyikriszta
approved these changes
Oct 12, 2025
gnclmorais
deleted the
fetch-only-chapter-organisers-on-workshop-edit-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were fetching and making it selectable all of the existing members, which actually slowed down the whole page when trying to edit organisers.