Skip to content

Nightly build posts results to slack app #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 17, 2021
Merged

Nightly build posts results to slack app #244

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
49e6828
Nightly build posts results to slack app
peterbriggs42 Feb 12, 2021
4a108a5
Only notify on failure; make a change to trigger a test failure
peterbriggs42 Feb 12, 2021
1257747
Try out a different action
peterbriggs42 Feb 16, 2021
69016fd
Change action again
peterbriggs42 Feb 16, 2021
3a9c12d
Tweak the fields displayed in slack message
peterbriggs42 Feb 16, 2021
cdfbe5a
Only post to slack on action failure, remove failing test
peterbriggs42 Feb 16, 2021
4653a5b
Make test fail again just to verify that we are still posting failure…
peterbriggs42 Feb 16, 2021
8af85fb
Roll back test failure
peterbriggs42 Feb 16, 2021
7865851
Fix whitespace
peterbriggs42 Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,12 @@ jobs:
env:
SSH_AUTH_SOCK: /tmp/ssh_agent.sock
run: tox -e nightly # Run tox using latest master branch from py42/c42eventextractor
- name: Notify Slack Action
uses: ravsamhq/[email protected]
if: always()
with:
status: ${{ job.status }}
notify_when: 'success,failure,warnings'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this only post on failure? In general I think its a good idea to only put something in the alerts channel when action is needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just added the other two statuses for testing purposes, to avoid needing to trigger a failure to verify the connection works. Will remove.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using a different action now, but it is configured to only post to Slack in the event of an action failure.

env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}