Nightly build posts results to slack app #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
alanag13
reviewed
Feb 12, 2021
.github/workflows/nightly.yml
Outdated
| if: always() | ||
| with: | ||
| status: ${{ job.status }} | ||
| notify_when: 'success,failure,warnings' |
There was a problem hiding this comment.
can we make this only post on failure? In general I think its a good idea to only put something in the alerts channel when action is needed.
There was a problem hiding this comment.
Yeah I just added the other two statuses for testing purposes, to avoid needing to trigger a failure to verify the connection works. Will remove.
There was a problem hiding this comment.
We are using a different action now, but it is configured to only post to Slack in the event of an action failure.
alanag13
reviewed
Feb 12, 2021
antazoey
approved these changes
Feb 17, 2021
alanag13
approved these changes
Feb 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/marketplace/actions/action-slack