Improvement/help #18
Merged
Improvement/help #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2020 17:38
antazoey
commented
Mar 16, 2020
| code42_arg_parser = ArgumentParser() | ||
| subcommand_parser = code42_arg_parser.add_subparsers() | ||
| description = u""" | ||
| Groups: |
There was a problem hiding this comment.
I wanted to call these top level subcommands "Groups" or "Modules". Azure calls them "groups". They are not really commands themselves, that is why.
There was a problem hiding this comment.
makes sense to me, and modules already means something different in both py42 and python itself.
added 14 commits
March 16, 2020 18:11
antazoey
commented
Mar 16, 2020
| """ | ||
| parser_profile = subcommand_parser.add_parser( | ||
| u"profile", | ||
| formatter_class=RawDescriptionHelpFormatter, |
There was a problem hiding this comment.
At this point, I really wish the profile module was broken up into subcommands the same way securitydata is. We also need a way a better to reuse some logic for some of these usage and description strings. This should be addressed on that refactoring ticket that we have though.
alanag13
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.