-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor repo after updating to React v16 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maddiedierker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR has a very large diff so i'm having difficulty understanding what optimizations were made and if there are any fixes related to the react upgrade. can you describe or leave comments around these specific changes?
most of this PR looks like clean-up work (mainly separating the massive ui.jsx file into separate files), so i want to make sure i'm reviewing this appropriately.
also, do you plan to merge this PR directly into main, or merge it into the branch in #396 first?
yeah, for now it's mostly cleanup work by separating the ui.jsx. The plan is refactoring step by step. First to separate the component so it would be either to navigate and understand the project and then do some more refactor. (Can be done in the third PR actually). This pr works both on react v15 and v16 so I'm thinking of merging it into main once it's done. (By that time I think the react update will probably merged into main anyways). |
|
thanks for confirming! that all makes sense. i'm interested in your thoughts on what we should refactor here, but if you've got a plan or an in-progress PR, you can just tag me on that. |
As for this PR I guess this might be it.
|
|
that all makes sense. regarding this point:
we're moving away from Radium in the code-dot-org repo and replacing it with CSS modules (using SCSS syntax), so we would likely want to use the same styling solution here as well |
Ok, cool, thanks. Will use it! |
breville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks reasonable. Thanks for taking an interest!
We must be careful to not regress any functionality. Does the tutorial operate the same through every user flow?
Yes, looks like everything works fine visually + test are passing successfuly |
Refactor after #397
No breaking changes, just refactor and optimization of repos codebase
The plan is to refactor React code step by step. (PR by PR)
In this PR I mainly separated the massive ui.jsx into separate components/files
This PR is not affecting #397 so can be merged anytime.