fix: Remove condition for aborted signal #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inesgomas
force-pushed
the
fix-aborted-request
branch
from
042f309 to
eb81a5a
Compare
joanasteodoro
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to fix these sentry reports:
After I did this change in some api requests I think it improved but we have many other api requests...
So I thought about going to the api repository and noticed we were avoiding throwing an error in case of aborted signal... But that is creating this case where it passes as a false positive, and then we throw errors because data was not returned...
I think it is better to throw the errors and handle abort signals as "don't show anything in the UI" instead. Like we already do in our handleException
The only consequence from this is that the aborts will show up as error messages in the console. But I think that is good.
I accept new ideas 😄