Skip to content

Fixing a crash in iOS 9.3.5 when we have a layer with WebView getting deallocated #20285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2019
Merged

Fixing a crash in iOS 9.3.5 when we have a layer with WebView getting deallocated #20285

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db8340
In case of iOS 9.3.5 when we show a web view and deallocate the layer…
deepshah7 Nov 1, 2019
a350e7d
Removing the autorelease and retain parts from the WKWebView instanti…
deepshah7 Nov 12, 2019
ce765aa
Changes so that we can remove the retain from the property declaratio…
deepshah7 Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cocos/ui/UIWebViewImpl-ios.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ - (void)dealloc {

- (void)setupWebView {
if (!self.wkWebView) {
self.wkWebView = [[[WKWebView alloc] init] autorelease];
self.wkWebView = [[[[WKWebView alloc] init] autorelease] retain];
self.wkWebView.UIDelegate = self;
self.wkWebView.navigationDelegate = self;
}
Expand Down