Skip to content

add setOptimise function for c++ #19882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 5, 2019
Merged

add setOptimise function for c++ #19882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9a43004
add setOptimise function for c++.
xianyinchen Jun 28, 2019
6f915c7
add setOptimise function for c++.
xianyinchen Jun 28, 2019
21c5186
add setOptimise function for c++.
xianyinchen Jul 2, 2019
1b59dca
add setOptimise function for c++
xianyinchen Jul 2, 2019
3a2daa7
add setOptimise function for c++
xianyinchen Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cocos/platform/CCDataManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,13 @@ void DataManager::onShaderLoaderEnd(){
JniHelper::callStaticVoidMethod(DataManagerClassName, "onShaderLoaderEnd");
#endif
}
void DataManager::setOptimise(const char* thing, const char* value){
if (nullptr == thing || nullptr == value){
return;
}
#if CC_TARGET_PLATFORM == CC_PLATFORM_ANDROID
JniHelper::callStaticVoidMethod(DataManagerClassName, "setOptimise", thing, value);
#endif
}

NS_CC_END
1 change: 1 addition & 0 deletions cocos/platform/CCDataManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ class CC_DLL DataManager
static void onSceneLoaderEnd();
static void onShaderLoaderBegin();
static void onShaderLoaderEnd();
static void setOptimise(const char* thing, const char* value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use const std::string& instead

};

// end of platform group
Expand Down