Skip to content

make code more clean and make comment more clear #19155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
Merged

make code more clean and make comment more clear #19155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions cocos/math/CCGeometry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,10 @@ float Rect::getMinY() const

bool Rect::containsPoint(const Vec2& point) const
{
bool bRet = false;

if (point.x >= getMinX() && point.x <= getMaxX()
&& point.y >= getMinY() && point.y <= getMaxY())
{
bRet = true;
}

return bRet;
return (point.x >= getMinX() &&
point.x <= getMaxX() &&
point.y >= getMinY() &&
point.y <= getMaxY());
}

bool Rect::intersectsRect(const Rect& rect) const
Expand Down
2 changes: 1 addition & 1 deletion cocos/math/CCGeometry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class CC_DLL Rect
*/
bool equals(const Rect& rect) const;
/**
Check if the points is contained in the rect.
Check if the points is contained inclusively in the rect.
* @js NA
*/
bool containsPoint(const Vec2& point) const;
Expand Down