CCFileUtils-win32::isFileExistInternal fails on a directory, while CCFileUtils-linux's doesn't

[tankorsmash]

Windows:

cocos2d-x/cocos/platform/win32/CCFileUtils-win32.cpp

Line 151 in b26e1bb

if(attr == INVALID_FILE_ATTRIBUTES || (attr & FILE_ATTRIBUTE_DIRECTORY))

Linux:

cocos2d-x/cocos/platform/linux/CCFileUtils-linux.cpp

Line 122 in b26e1bb

return (stat(strPath.c_str(), &sts) != -1) ? true : false;

The C++ file to test the result of stat on linux, result is 0 on a dir that exists:

#include <unistd.h>
#include <sys/stat.h>
#include <stdio.h>
#include <iostream>

int main()
{
	struct stat sts;
	auto result = stat("a dir that exists on your machine/", &sts);
	std::cout << "result is: " << result;
	return 0;
};

whereas attr = GetFileAttributesW("a dir that exists") does result in attr & FILE_ATTRIBUTE_DIRECTORY being non-zero.

This seems to mean CCFileUtilsWin32::listFiles can't work, because https://github.com/cocos2d/cocos2d-x/blob/v3/cocos/platform/win32/CCFileUtils-win32.cpp#L276 will always return "", since it ends up going down to CCFileUtils-win32::isFileExistInternal and failing.

[PatriceJiang]

This seems to mean CCFileUtilsWin32::listFiles can't work

This bug was fixed in a recent PR.
https://github.com/cocos2d/cocos2d-x/pull/19044/files#diff-cb65223cd3edf30671fefad4a1883edf

I think the Linux version of isFileExistInternal should not accept a folder, cause isDirecotryExistInternal exists at the same level.

[tankorsmash]

That does seem to be the case, thanks! So this is fixed in #19044

[PatriceJiang]

similar issue #18835