Skip to content

Conversation

rmloveland
Copy link
Contributor

Fixes DOC-13580

Copy link

netlify bot commented May 6, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 51b3742
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6824dce3a10c0a0008ce344a

Copy link

netlify bot commented May 6, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 51b3742
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6824dce37d7e7a00083767c9

@rmloveland rmloveland requested a review from dikshant May 6, 2025 15:08
@rmloveland
Copy link
Contributor Author

@dikshant this is v25.2 for ease of review, i will backport changes once they look good

Copy link

netlify bot commented May 6, 2025

Netlify Preview

Name Link
🔨 Latest commit 51b3742
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6824dce363b4470008679d28
😎 Deploy Preview https://deploy-preview-19585--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

@rmloveland rmloveland requested a review from taroface May 7, 2025 16:05
@rmloveland
Copy link
Contributor Author

@taroface FYI this is an opportunistic PR, can be reviewed after v25.2 things if that's easier!

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some non-blocking nits

@rmloveland
Copy link
Contributor Author

thanks @taroface !!!!

@rmloveland rmloveland enabled auto-merge (squash) May 14, 2025 18:11
@rmloveland rmloveland merged commit 6667ddb into main May 14, 2025
6 checks passed
@rmloveland rmloveland deleted the 20250506-alter-role-all-clarification branch May 14, 2025 18:25
rmloveland added a commit that referenced this pull request May 15, 2025
rmloveland added a commit that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants