Skip to content

Conversation

@aerfrei
Copy link
Contributor

@aerfrei aerfrei commented Oct 9, 2025

Backport 1/1 commits from #152689 on behalf of @aerfrei.


Previously, this test would flake because a table that we were asserting the admin user could see hadn't yet become visible. Now we assert the changefeed and rangefeed have started by waiting for a highwater mark.

Epic: none
Fixes: #152060

Release note: None


Release justification: Test only change in response to test flake

Previously, this test would flake because a table that we
were asserting the admin user could see hadn't yet become
visible. Now we assert the changefeed and rangefeed have
started by waiting for a highwater mark.

Epic: none
Fixes: cockroachdb#152060

Release note: None
@aerfrei aerfrei requested a review from a team as a code owner October 9, 2025 21:12
@aerfrei aerfrei requested review from rharding6373 and removed request for a team October 9, 2025 21:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Oct 9, 2025
@blathers-crl
Copy link

blathers-crl bot commented Oct 9, 2025

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes. Includes test-only changes, build system changes, etc.
  • Fixes for serious issues. Defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to.

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-cdc labels Oct 9, 2025
@blathers-crl
Copy link

blathers-crl bot commented Oct 9, 2025

✅ PR #155191 is compliant with backport policy

Confidence: high
Backward compatible: true
Explanation: The pull request modifies a test file pkg/ccl/changefeedccl/changefeed_test.go, which is classified under non-production code. Since only test files are affected, this PR falls within the non-production changes exception of the backport policy. Furthermore, the PR body includes a 'Release justification:' line stating 'Test only change in response to test flake', which specifies that this is an exempt change due to it being a response to test instability.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Oct 9, 2025
@aerfrei aerfrei merged commit 06f4114 into cockroachdb:release-24.3 Oct 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-cdc target-release-24.3.22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants