spanconfigreconcilerccl: deflake spanconfigreconcilerccl_test #155167
Conversation
Previously, the span config reconciller tests when running under a tenant did not use the transactional descriptor ID generator, which could lead to flake. Additionally, the transactional ID generator also was not being used for creating internal objects, when the testing knob is enabled. This patch fixes the multi-tenant tests to use the transactional ID generator and enables it for internal queries as well. Fixes: cockroachdb#154585 Release note: None
fqazi
added
the
backport-all
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
| p.extendedEvalCtx.NodeID = execCfg.NodeInfo.NodeID | ||
| p.extendedEvalCtx.Locality = execCfg.Locality | ||
| p.extendedEvalCtx.DescIDGenerator = execCfg.DescIDGenerator | ||
| if execCfg.TestingKnobs.UseTransactionalDescIDGenerator && txn != nil { |
There was a problem hiding this comment.
ah nice find. this probably would have been affecting other tests too.
|
@rafiss TFTR bors r+ |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 26f37dd to blathers/backport-release-24.1-155167: POST https://api.github.com/repos/fqazi/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.1 failed. See errors above. error creating merge commit from 26f37dd to blathers/backport-release-24.3-155167: POST https://api.github.com/repos/fqazi/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.3 failed. See errors above. error creating merge commit from 26f37dd to blathers/backport-release-25.2-155167: POST https://api.github.com/repos/fqazi/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-25.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
3 participants
Previously, the span config reconciller tests when running under a tenant did not use the transactional descriptor ID generator, which could lead to flake. Additionally, the transactional ID generator also was not being used for creating internal objects, when the testing knob is enabled. This patch fixes the multi-tenant tests to use the transactional ID generator and enables it for internal queries as well.
Fixes: #154585
Release note: None