Skip to content

Conversation

@allisonkarlitskaya
Copy link
Member

This can be helpful if you want to trigger something like '/networking@', for example.

None of our repositories use this name anymore and I don't expect we'll
ever see any others that do.

Keep the infrastructure for per-project main branches in place in case
some day we add another repo that uses a name other than 'main'.
This can be helpful if you want to trigger something like
'*/networking@*', for example.
@allisonkarlitskaya
Copy link
Member Author

So I did this from the standpoint of running it from the bots repository itself, similar to image:. Maybe that's not right. I think maybe we also want to consider that it's run from the individual target repositories and then limit it to the scenarios defined on that repo?

if branch.startswith('_'):
continue
for context in contexts:
c = context + '@' + repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like you say this probably isn't right. I think this should work on the target repository so when I do

./tests-trigger --repo cockpit-project/cockpit 22330 '*/networking'

I'd like to trigger all images that run cockpit tests and their /networking scenario

@tomasmatus
Copy link
Member

I'd say it's fine to only support wildcard match for image variants and maybe contexts for specific image? So basically */networking or fedora-42/* and the latter kinda only makes sense for cockpit. What do you think?

@allisonkarlitskaya
Copy link
Member Author

I'd say it's fine to only support wildcard match for image variants and maybe contexts for specific image? So basically */networking or fedora-42/* and the latter kinda only makes sense for cockpit. What do you think?

I kinda feel like doing it at the string level is actually easier... it might be "too powerful" in some sense, but it's also just kinda the easiest way to do it...

But probably we do need to do something about the launch context: if we're in a repo other than bots we probably want to only refer to the contexts present in that repo. I'll redo this a bit...

@martinpitt martinpitt marked this pull request as draft September 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants