Skip to content

Conversation

@melange396
Copy link
Contributor

dont overwrite 'title' with 'customtitle' but use custom in place of title (when available). also, add custom to url-encoded shared links.

@melange396 melange396 requested a review from dmytrotsko April 1, 2025 22:17
@melange396
Copy link
Contributor Author

To demonstrate the bad/bugged behavior:

  1. open https://delphi.cmu.edu/epivis/
  2. add a dataset (one from the covidcast indicators endpoint is recommended)
  3. hit the "link to this view" button and copy the provided URL to your clipboard
  4. open a new tab and paste the url, then hit enter
  5. observe the same datasets are displayed (you can also get to this step via the epiportal discovery app)
  6. add another dataset
  7. again hit the "link to this view" button and copy the provided URL to your clipboard
  8. again open a new tab and paste the url, then hit enter
  9. observe only the most recent dataset is shown, and the prior ones are gone

To demonstrate the fixed behavior:

Copy link

@dmytrotsko dmytrotsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396 melange396 merged commit c287203 into dev Apr 9, 2025
6 checks passed
@melange396 melange396 deleted the fix_reshare branch April 9, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants