Update where in the app data is being pulled from AWS #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateharwood
changed the title
tildechris
reviewed
Mar 25, 2021
tildechris
reviewed
Mar 25, 2021
| if(!is.null(s3bucket)) { | ||
| tryCatch( | ||
| { | ||
| s3readRDS(object = filename, bucket = s3bucket) |
There was a problem hiding this comment.
I think this may read this for every new session. The score cards are pretty small, but it could introduce a load time problem eventually.
There was a problem hiding this comment.
The methods of reloading the app from within the app that I've seen do not actually restart the app, so I think this code has to be within the server to get re-run, unless there is another way of doing it that I haven't seen yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully with the data retrieval happening in the server function, the app will pull down the data each time it is reloaded, and not only on a full app restart.